Messages in this thread | | | Date | Wed, 20 Sep 2017 18:29:49 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH] block: consider merge of segments when merge bio into rq |
| |
So the check change here looks good to me.
I don't like like the duplicate code, can you look into sharing the new segment checks between the two functions and the existing instance in ll_merge_requests_fn by passing say two struct bio *bio1 and struct bio *bio2 pointer instead of using req->bio and req->biotail?
Also please include the information that you posted in the reply to the other patch in the description for this one.
| |