Messages in this thread | | | Subject | Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" | From | Mark yao <> | Date | Thu, 21 Sep 2017 09:02:22 +0800 |
| |
On 2017年09月21日 06:29, Thomas Meyer wrote: > Use vma_pages function on vma object instead of explicit computation. > Found by coccinelle spatch "api/vma_pages.cocci" > > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> > --- Looks good for me: Acked-by: Mark Yao <mark.yao@rock-chips.com>
> > diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ > { > struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); > unsigned int i, count = obj->size >> PAGE_SHIFT; > - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > + unsigned long user_count = vma_pages(vma); > unsigned long uaddr = vma->vm_start; > unsigned long offset = vma->vm_pgoff; > unsigned long end = user_count + offset; > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > >
-- Mark Yao
| |