lkml.org 
[lkml]   [2017]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"
From
Date
On 2017年09月21日 06:29, Thomas Meyer wrote:
> Use vma_pages function on vma object instead of explicit computation.
> Found by coccinelle spatch "api/vma_pages.cocci"
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
Looks good for me:
Acked-by: Mark Yao <mark.yao@rock-chips.com>

>
> diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_
> {
> struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj);
> unsigned int i, count = obj->size >> PAGE_SHIFT;
> - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> + unsigned long user_count = vma_pages(vma);
> unsigned long uaddr = vma->vm_start;
> unsigned long offset = vma->vm_pgoff;
> unsigned long end = user_count + offset;
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
>
>

--
Mark Yao


\
 
 \ /
  Last update: 2017-09-21 19:26    [W:0.144 / U:0.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site