Messages in this thread | | | Date | Wed, 20 Sep 2017 14:22:27 -0700 (PDT) | Subject | Re: [Patch v3 1/3] ipv4: Namespaceify tcp_fastopen knob | From | David Miller <> |
| |
From: Haishuang Yan <yanhaishuang@cmss.chinamobile.com> Date: Tue, 19 Sep 2017 17:38:14 +0800
> - if ((sysctl_tcp_fastopen & TFO_SERVER_WO_SOCKOPT1) && > - (sysctl_tcp_fastopen & TFO_SERVER_ENABLE) && > + tcp_fastopen = sock_net(sk)->ipv4.sysctl_tcp_fastopen; ^^
Please change that to one space.
And also please provide an appropriate "[PATCH vX 0/3] " header posting when you respin this series.
> @@ -282,18 +280,19 @@ struct sock *tcp_try_fastopen(struct sock *sk, struct sk_buff *skb, > struct tcp_fastopen_cookie valid_foc = { .len = -1 }; > bool syn_data = TCP_SKB_CB(skb)->end_seq != TCP_SKB_CB(skb)->seq + 1; > struct sock *child; > + int tcp_fastopen = sock_net(sk)->ipv4.sysctl_tcp_fastopen;
Please order local variables from longest to shortest line (aka. reverse christmas tree format).
| |