Messages in this thread | | | From | Guenter Roeck <> | Date | Tue, 19 Sep 2017 18:45:46 -0700 | Subject | Re: [PATCH] HID: hidraw: fix power sequence when closing device |
| |
On Tue, Sep 19, 2017 at 6:37 PM, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > We should not try to bring HID device out of full power state before > calling hid_hw_close(), so that transport driver operates on powered up > device (making this inverse of the opening sequence). > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> --- > drivers/hid/hidraw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c > index ec530454e6f6..5fbe0f81ab2e 100644 > --- a/drivers/hid/hidraw.c > +++ b/drivers/hid/hidraw.c > @@ -337,8 +337,8 @@ static void drop_ref(struct hidraw *hidraw, int exists_bit) > kfree(hidraw); > } else { > /* close device for last reader */ > - hid_hw_power(hidraw->hid, PM_HINT_NORMAL); > hid_hw_close(hidraw->hid); > + hid_hw_power(hidraw->hid, PM_HINT_NORMAL); > } > } > } > -- > 2.14.1.821.g8fa685d3b7-goog > > > -- > Dmitry
| |