Messages in this thread | | | From | Thomas Meyer <> | Subject | Re: [PATCH V2] tipc: Use bsearch library function | Date | Sun, 17 Sep 2017 17:00:12 +0200 |
| |
> Am 16.09.2017 um 15:20 schrieb Jon Maloy <jon.maloy@ericsson.com>. >> >> What part of "very time critical" have you verified and benchmarked as >> inconsequential? >> >> Please post your results. > > I agree with Joe here. This change does not simplify anything, it does not reduce the amount of code, plus that it introduce an unnecessary outline call in a place where we have every reason to let the compiler do its optimization job properly.
Hi,
Okay, should I prepare some performance numbers or do we NAK this change? What about the other binary search implementation in the same file? Should I try to convert it it will it get NAKed for performance reasons too?
With kind regards Thomas[unhandled content-type:application/pkcs7-signature]
| |