Messages in this thread | | | Date | Mon, 11 Sep 2017 12:42:01 -0700 | From | Benson Leung <> | Subject | Re: [PATCH v2 8/8] platform/chrome: cros_ec: sysfs: Modify error handling |
| |
Hi Thierry,
On Fri, Aug 11, 2017 at 04:23:05PM +0200, Thierry Escande wrote: > From: Gwendal Grignou <gwendal@chromium.org> > > When accessing a sysfs attribute, if the EC command fails, -EPROTO is > now returned instead of an error message as it is unlikely an app is > parsing the error message to do something meaningful. > Also, this patch makes use of cros_ec_cmd_xfer_status() instead of > cros_ec_cmd_xfer() so an error message is printed in the syslog. > > Signed-off-by: Gwendal Grignou <gwendal@chromium.org> > Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
Looks good. Applied.
-- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org [unhandled content-type:application/pgp-signature] | |