lkml.org 
[lkml]   [2017]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFC PATCH 0/3] kbuild: generate intermediate C files instead of copying _shipped files
    On Sun, Sep 10, 2017 at 6:58 AM, Masahiro Yamada
    <yamada.masahiro@socionext.com> wrote:
    >
    > "is_reserved_word()" sounds like a boolean function
    > that returns 1 or 0.
    > Maybe, the choice of the function name was not nice.

    Yeah, not great name. That's the old name, though - I didn't change
    that part, I just changed how it used to return the token structure
    pointer, which would be NULL when it wasn't a keyword.

    I actually *should* have made it just return 0 for the "not a keyword"
    case rather than -1, and that would have ended up being semantically
    closer to the old use (because you could treat the return value as a
    boolean, like you could with the token pointer). But it's been
    literally decades since I used bison/flex, and I didn't remember the
    rules for 'enum yytokentype', so I just thought "negative numbers for
    error" was safer. Zero would have been fine, no token can have that
    number anyway (it just means EOF).

    And negative wasn't safer, it caused that bug due to the bare boolean
    use I hadn't noticed.

    Oh well.

    Linus

    \
     
     \ /
      Last update: 2017-09-10 18:29    [W:6.635 / U:0.376 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site