Messages in this thread | | | Date | Fri, 01 Sep 2017 10:34:08 -0700 (PDT) | Subject | Re: [PATCH] qlcnic: remove redundant zero check on retries counter | From | David Miller <> |
| |
From: Colin King <colin.king@canonical.com> Date: Fri, 1 Sep 2017 14:44:31 +0100
> From: Colin Ian King <colin.king@canonical.com> > > At the end of the do while loop the integer counter retries will > always be zero and so the subsequent check to see if it is zero > is always true and therefore redundant. Remove the redundant check > and always return -EIO on this return path. Also unbreak the literal > string in dev_err message to clean up a checkpatch warning. > > Detected by CoverityScan, CID#744279 ("Logically dead code") > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to net-next, thanks.
| |