Messages in this thread Patch in this message | | | Subject | [PATCH v2 2/4] ACPI-APEI-HEST: Use kmalloc_array() in hest_ghes_dev_register() | From | SF Markus Elfring <> | Date | Wed, 9 Aug 2017 20:02:50 +0200 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Mon, 5 Sep 2016 20:55:33 +0200
* A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus reuse the corresponding function "kmalloc_array".
This issue was detected by using the Coccinelle software.
* Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/acpi/apei/hest.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c index 832a930e98f2..24d1d3cd3371 100644 --- a/drivers/acpi/apei/hest.c +++ b/drivers/acpi/apei/hest.c @@ -195,7 +195,9 @@ static int __init hest_ghes_dev_register(unsigned int ghes_count) struct ghes_arr ghes_arr; ghes_arr.count = 0; - ghes_arr.ghes_devs = kmalloc(sizeof(void *) * ghes_count, GFP_KERNEL); + ghes_arr.ghes_devs = kmalloc_array(ghes_count, + sizeof(*ghes_arr.ghes_devs), + GFP_KERNEL); if (!ghes_arr.ghes_devs) return -ENOMEM; -- 2.13.4
| |