| From | Greg Kroah-Hartman <> | Subject | [PATCH 4.12 065/106] wireless: wext: terminate ifr name coming from userspace | Date | Wed, 9 Aug 2017 09:52:49 -0700 |
| |
4.12-stable review patch. If anyone has any objections, please let me know.
------------------
From: "Levin, Alexander" <alexander.levin@verizon.com>
[ Upstream commit 98de4e0ea47d106846fc0e30ce4e644283fa7fc2 ]
ifr name is assumed to be a valid string by the kernel, but nothing was forcing username to pass a valid string.
In turn, this would cause panics as we tried to access the string past it's valid memory.
Signed-off-by: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- net/core/dev_ioctl.c | 2 ++ 1 file changed, 2 insertions(+)
--- a/net/core/dev_ioctl.c +++ b/net/core/dev_ioctl.c @@ -423,6 +423,8 @@ int dev_ioctl(struct net *net, unsigned if (copy_from_user(&iwr, arg, sizeof(iwr))) return -EFAULT; + iwr.ifr_name[sizeof(iwr.ifr_name) - 1] = 0; + return wext_handle_ioctl(net, &iwr, cmd, arg); }
|