Messages in this thread | | | Date | Tue, 8 Aug 2017 16:36:43 -0600 | From | Jason Gunthorpe <> | Subject | Re: [PATCH] tpm/tpm_crb: Access locality for only CRB_START method |
| |
On Sun, Aug 06, 2017 at 09:54:15PM -0500, Jiandi An wrote:
> static int __maybe_unused crb_go_idle(struct device *dev, struct crb_priv *priv) > { > - if ((priv->flags & CRB_FL_ACPI_START) || > - (priv->flags & CRB_FL_CRB_SMC_START)) > + if (!(priv->flags & CRB_FL_CRB_START))
I think it would be better to have these list the cases where go_idle is known to be required. Less brittle that way..
if ((priv->flags & (CRB_FL_ACPI_START | CRB_FL_CRB_START)) == 0) return 0
> - if (!(priv->flags & CRB_FL_ACPI_START)) { > + if (priv->flags & CRB_FL_CRB_START) {
Eg like this now makes more sense, assumming CRB_START is the right test :)
Jason
| |