Messages in this thread | | | Date | Tue, 8 Aug 2017 11:03:04 +0100 | From | Lee Jones <> | Subject | Re: [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices |
| |
On Sun, 30 Jul 2017, Axel Lin wrote:
> This fixes missing mfd_remove_devices() call when unload the module. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > drivers/mfd/lp87565.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/lp87565.c b/drivers/mfd/lp87565.c > index 340ad0c..32d2a07 100644 > --- a/drivers/mfd/lp87565.c > +++ b/drivers/mfd/lp87565.c > @@ -73,10 +73,9 @@ static int lp87565_probe(struct i2c_client *client, > > i2c_set_clientdata(client, lp87565); > > - ret = mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO, lp87565_cells, > - ARRAY_SIZE(lp87565_cells), NULL, 0, NULL); > - > - return ret; > + return devm_mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO, > + lp87565_cells, ARRAY_SIZE(lp87565_cells), > + NULL, 0, NULL); > } > > static const struct i2c_device_id lp87565_id_table[] = {
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |