Messages in this thread | | | From | Kai-Heng Feng <> | Date | Tue, 8 Aug 2017 17:10:51 +0800 | Subject | Re: [PATCH v2] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter |
| |
On Tue, Aug 8, 2017 at 4:28 PM, Oliver Neukum <oneukum@suse.com> wrote: > Am Dienstag, den 08.08.2017, 14:32 +0800 schrieb Kai-Heng Feng: >> Moshi USB to Ethernet Adapter internally uses a Genesys Logic hub to >> connect to Realtek r8153. >> >> The Realtek r8153 ethernet does not work on the internal hub, no-lpm quirk >> can make it work. >> >> Since another r8153 dongle at my hand does not have the issue, so add >> the quirk to the hub instead. > > But in the comment you say you add it to the device! > This makes no sense.
You are right, I forgot to update the comment. My bad.
> > [..] >> + /* Moshi USB to Ethernet Adapter */ >> + { USB_DEVICE(0x05e3, 0x0616), .driver_info = USB_QUIRK_NO_LPM }, >> + > > Now is this a hub or a device? If this is a Genesys Logic hub, > you need to say that clearly and state that it is an internal hub.
It's the Genesys Logic hub that being used internally.
I'll update the comment more clearly.
Thanks.
> > Regards > Oliver >
| |