lkml.org 
[lkml]   [2017]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 046/105] x86/mce/AMD: Make the init code more robust
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Thomas Gleixner <tglx@linutronix.de>


    [ Upstream commit 0dad3a3014a0b9e72521ff44f17e0054f43dcdea ]

    If mce_device_init() fails then the mce device pointer is NULL and the
    AMD mce code happily dereferences it.

    Add a sanity check.

    Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de>
    Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/x86/kernel/cpu/mcheck/mce_amd.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/arch/x86/kernel/cpu/mcheck/mce_amd.c
    +++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c
    @@ -955,6 +955,9 @@ static int threshold_create_bank(unsigne
    const char *name = get_name(bank, NULL);
    int err = 0;

    + if (!dev)
    + return -ENODEV;
    +
    if (is_shared_bank(bank)) {
    nb = node_to_amd_nb(amd_get_nb_id(cpu));


    \
     
     \ /
      Last update: 2017-08-05 02:09    [W:3.625 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site