lkml.org 
[lkml]   [2017]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 088/105] video: fbdev: cobalt_lcdfb: Handle return NULL error from devm_ioremap
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Arvind Yadav <arvind.yadav.cs@gmail.com>


    [ Upstream commit 4dcd19bfabaee8f9f4bcf203afba09b98ccbaf76 ]

    Here, If devm_ioremap will fail. It will return NULL.
    Kernel can run into a NULL-pointer dereference.
    This error check will avoid NULL pointer dereference.

    Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    Acked-by: Yoichi Yuasa <yuasa@linux-mips.org>
    Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/video/fbdev/cobalt_lcdfb.c | 5 +++++
    1 file changed, 5 insertions(+)

    --- a/drivers/video/fbdev/cobalt_lcdfb.c
    +++ b/drivers/video/fbdev/cobalt_lcdfb.c
    @@ -308,6 +308,11 @@ static int cobalt_lcdfb_probe(struct pla
    info->screen_size = resource_size(res);
    info->screen_base = devm_ioremap(&dev->dev, res->start,
    info->screen_size);
    + if (!info->screen_base) {
    + framebuffer_release(info);
    + return -ENOMEM;
    + }
    +
    info->fbops = &cobalt_lcd_fbops;
    info->fix = cobalt_lcdfb_fix;
    info->fix.smem_start = res->start;

    \
     
     \ /
      Last update: 2017-08-05 01:24    [W:4.170 / U:0.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site