Messages in this thread | | | Subject | Re: [PATCH] leds: blinkm: constify attribute_group structures. | From | Jacek Anaszewski <> | Date | Fri, 4 Aug 2017 21:57:33 +0200 |
| |
Hi Arvind,
Thanks for the patch.
On 08/04/2017 08:25 AM, Arvind Yadav wrote: > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by <linux/sysfs.h> work with > const attribute_group. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > drivers/leds/leds-blinkm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c > index 617fe97..d03ed6b 100644 > --- a/drivers/leds/leds-blinkm.c > +++ b/drivers/leds/leds-blinkm.c > @@ -298,7 +298,7 @@ static ssize_t store_test(struct device *dev, struct device_attribute *attr, > NULL, > }; > > -static struct attribute_group blinkm_group = { > +static const struct attribute_group blinkm_group = { > .name = "blinkm", > .attrs = blinkm_attrs, > }; >
Applied to the for-next branch of linux-leds.git.
-- Best regards, Jacek Anaszewski
| |