lkml.org 
[lkml]   [2017]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 07/11] drm: i915: i915_oa_kblgt3: constify attribute_group structures.
    Date
    attribute_group are not supposed to change at runtime. All functions
    working with attribute_group provided by <linux/sysfs.h> work with
    const attribute_group. So mark the non-const structs as const.

    Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    ---
    drivers/gpu/drm/i915/i915_oa_kblgt3.c | 36 +++++++++++++++++------------------
    1 file changed, 18 insertions(+), 18 deletions(-)

    diff --git a/drivers/gpu/drm/i915/i915_oa_kblgt3.c b/drivers/gpu/drm/i915/i915_oa_kblgt3.c
    index 6ed0925..f234801 100644
    --- a/drivers/gpu/drm/i915/i915_oa_kblgt3.c
    +++ b/drivers/gpu/drm/i915/i915_oa_kblgt3.c
    @@ -2461,7 +2461,7 @@ int i915_oa_select_metric_set_kblgt3(struct drm_i915_private *dev_priv)
    NULL,
    };

    -static struct attribute_group group_render_basic = {
    +static const struct attribute_group group_render_basic = {
    .name = "0286c920-2f6d-493b-b22d-7a5280df43de",
    .attrs = attrs_render_basic,
    };
    @@ -2483,7 +2483,7 @@ int i915_oa_select_metric_set_kblgt3(struct drm_i915_private *dev_priv)
    NULL,
    };

    -static struct attribute_group group_compute_basic = {
    +static const struct attribute_group group_compute_basic = {
    .name = "9823aaa1-b06f-40ce-884b-cd798c79f0c2",
    .attrs = attrs_compute_basic,
    };
    @@ -2505,7 +2505,7 @@ int i915_oa_select_metric_set_kblgt3(struct drm_i915_private *dev_priv)
    NULL,
    };

    -static struct attribute_group group_render_pipe_profile = {
    +static const struct attribute_group group_render_pipe_profile = {
    .name = "c7c735f3-ce58-45cf-aa04-30b183f1faff",
    .attrs = attrs_render_pipe_profile,
    };
    @@ -2527,7 +2527,7 @@ int i915_oa_select_metric_set_kblgt3(struct drm_i915_private *dev_priv)
    NULL,
    };

    -static struct attribute_group group_memory_reads = {
    +static const struct attribute_group group_memory_reads = {
    .name = "96ec2219-040b-428a-856a-6bc03363a057",
    .attrs = attrs_memory_reads,
    };
    @@ -2549,7 +2549,7 @@ int i915_oa_select_metric_set_kblgt3(struct drm_i915_private *dev_priv)
    NULL,
    };

    -static struct attribute_group group_memory_writes = {
    +static const struct attribute_group group_memory_writes = {
    .name = "03372b64-4996-4d3b-aa18-790e75eeb9c2",
    .attrs = attrs_memory_writes,
    };
    @@ -2571,7 +2571,7 @@ int i915_oa_select_metric_set_kblgt3(struct drm_i915_private *dev_priv)
    NULL,
    };

    -static struct attribute_group group_compute_extended = {
    +static const struct attribute_group group_compute_extended = {
    .name = "31b4ce5a-bd61-4c1f-bb5d-f2e731412150",
    .attrs = attrs_compute_extended,
    };
    @@ -2593,7 +2593,7 @@ int i915_oa_select_metric_set_kblgt3(struct drm_i915_private *dev_priv)
    NULL,
    };

    -static struct attribute_group group_compute_l3_cache = {
    +static const struct attribute_group group_compute_l3_cache = {
    .name = "2ce0911a-27fc-4887-96f0-11084fa807c3",
    .attrs = attrs_compute_l3_cache,
    };
    @@ -2615,7 +2615,7 @@ int i915_oa_select_metric_set_kblgt3(struct drm_i915_private *dev_priv)
    NULL,
    };

    -static struct attribute_group group_hdc_and_sf = {
    +static const struct attribute_group group_hdc_and_sf = {
    .name = "546c4c1d-99b8-42fb-a107-5aaabb5314a8",
    .attrs = attrs_hdc_and_sf,
    };
    @@ -2637,7 +2637,7 @@ int i915_oa_select_metric_set_kblgt3(struct drm_i915_private *dev_priv)
    NULL,
    };

    -static struct attribute_group group_l3_1 = {
    +static const struct attribute_group group_l3_1 = {
    .name = "4e93d156-9b39-4268-8544-a8e0480806d7",
    .attrs = attrs_l3_1,
    };
    @@ -2659,7 +2659,7 @@ int i915_oa_select_metric_set_kblgt3(struct drm_i915_private *dev_priv)
    NULL,
    };

    -static struct attribute_group group_l3_2 = {
    +static const struct attribute_group group_l3_2 = {
    .name = "de1bec86-ca92-4b43-89fa-147653221cc0",
    .attrs = attrs_l3_2,
    };
    @@ -2681,7 +2681,7 @@ int i915_oa_select_metric_set_kblgt3(struct drm_i915_private *dev_priv)
    NULL,
    };

    -static struct attribute_group group_l3_3 = {
    +static const struct attribute_group group_l3_3 = {
    .name = "e63537bb-10be-4d4a-92c4-c6b0c65e02ef",
    .attrs = attrs_l3_3,
    };
    @@ -2703,7 +2703,7 @@ int i915_oa_select_metric_set_kblgt3(struct drm_i915_private *dev_priv)
    NULL,
    };

    -static struct attribute_group group_rasterizer_and_pixel_backend = {
    +static const struct attribute_group group_rasterizer_and_pixel_backend = {
    .name = "7a03a9f8-ec5e-46bb-8b67-1f0ff1476281",
    .attrs = attrs_rasterizer_and_pixel_backend,
    };
    @@ -2725,7 +2725,7 @@ int i915_oa_select_metric_set_kblgt3(struct drm_i915_private *dev_priv)
    NULL,
    };

    -static struct attribute_group group_sampler = {
    +static const struct attribute_group group_sampler = {
    .name = "b25d2ebf-a6e0-4b29-96be-a9b010edeeda",
    .attrs = attrs_sampler,
    };
    @@ -2747,7 +2747,7 @@ int i915_oa_select_metric_set_kblgt3(struct drm_i915_private *dev_priv)
    NULL,
    };

    -static struct attribute_group group_tdl_1 = {
    +static const struct attribute_group group_tdl_1 = {
    .name = "469a05e5-e299-46f7-9598-7b05f3c34991",
    .attrs = attrs_tdl_1,
    };
    @@ -2769,7 +2769,7 @@ int i915_oa_select_metric_set_kblgt3(struct drm_i915_private *dev_priv)
    NULL,
    };

    -static struct attribute_group group_tdl_2 = {
    +static const struct attribute_group group_tdl_2 = {
    .name = "52f925c6-786a-4ec6-86ce-cba85c83453a",
    .attrs = attrs_tdl_2,
    };
    @@ -2791,7 +2791,7 @@ int i915_oa_select_metric_set_kblgt3(struct drm_i915_private *dev_priv)
    NULL,
    };

    -static struct attribute_group group_compute_extra = {
    +static const struct attribute_group group_compute_extra = {
    .name = "efc497ac-884e-4ee4-a4a8-15fba22aaf21",
    .attrs = attrs_compute_extra,
    };
    @@ -2813,7 +2813,7 @@ int i915_oa_select_metric_set_kblgt3(struct drm_i915_private *dev_priv)
    NULL,
    };

    -static struct attribute_group group_vme_pipe = {
    +static const struct attribute_group group_vme_pipe = {
    .name = "bfd9764d-2c5b-4c16-bfc1-89de3ca10917",
    .attrs = attrs_vme_pipe,
    };
    @@ -2835,7 +2835,7 @@ int i915_oa_select_metric_set_kblgt3(struct drm_i915_private *dev_priv)
    NULL,
    };

    -static struct attribute_group group_test_oa = {
    +static const struct attribute_group group_test_oa = {
    .name = "f1792f32-6db2-4b50-b4b2-557128f1688d",
    .attrs = attrs_test_oa,
    };
    --
    1.9.1
    \
     
     \ /
      Last update: 2017-08-04 07:05    [W:6.915 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site