Messages in this thread | | | From | Dmitry Torokhov <> | Date | Thu, 31 Aug 2017 18:06:29 -0700 | Subject | Re: [PATCH 31/31] timer: Switch to testing for .function instead of .data |
| |
On Thu, Aug 31, 2017 at 4:59 PM, Kees Cook <keescook@chromium.org> wrote: > On Thu, Aug 31, 2017 at 4:45 PM, Dmitry Torokhov > <dmitry.torokhov@gmail.com> wrote: >> On Thu, Aug 31, 2017 at 4:29 PM, Kees Cook <keescook@chromium.org> wrote: >>> In several places, .data is checked for initialization to gate early >>> calls to del_timer_sync(). Checking for .function is equally valid, so >>> switch to this in all callers. >> >> Not seeing the rest of patches it is unclear from the patch >> description why this is needed/wanted. > > The CC list would have been really giant, but here is the first patch > and the earlier series list: > > https://lkml.org/lkml/2017/8/31/904 > https://lkml.org/lkml/2017/8/30/760 > > tl;dr: We're going to switch all struct timer_list callbacks to get > the timer pointer as the argument instead of from the .data field. > This patch is one step in removing open-coded users of the .data > field. >
And that is exactly what should have been in the patch description.
FWIW for input bits:
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Thanks.
-- Dmitry
| |