Messages in this thread | | | Date | Wed, 30 Aug 2017 08:42:04 -0700 | From | Sinclair Yeh <> | Subject | Re: [PATCH] drm: vmwgfx: constify vmw_fence_ops |
| |
On Wed, Aug 30, 2017 at 10:30:24AM +0200, Daniel Vetter wrote: > On Wed, Aug 30, 2017 at 08:21:46AM +0200, Thomas Hellstrom wrote: > > On 08/30/2017 07:47 AM, Arvind Yadav wrote: > > > vmw_fence_ops are not supposed to change at runtime. Functions > > > "dma_fence_init" working with const vmw_fence_ops provided > > > by <linux/dma-fence.h>. So mark the non-const structs as const. > > > > > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > > > --- > > > drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c > > > index b8bc5bc..abc5f03 100644 > > > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c > > > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c > > > @@ -225,7 +225,7 @@ static long vmw_fence_wait(struct dma_fence *f, bool intr, signed long timeout) > > > return ret; > > > } > > > -static struct dma_fence_ops vmw_fence_ops = { > > > +static const struct dma_fence_ops vmw_fence_ops = { > > > .get_driver_name = vmw_fence_get_driver_name, > > > .get_timeline_name = vmw_fence_get_timeline_name, > > > .enable_signaling = vmw_fence_enable_signaling, > > > > Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com> > > Does this mean you'll merge it, or does this mean you'll expect someone > else to merge this?
Yes, we have this queued and will go out in the next pull request.
| |