lkml.org 
[lkml]   [2017]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 10/16] btrfs: switch write_buf to kernel_write
From
Date


On 30.08.2017 18:00, Christoph Hellwig wrote:
> Instead of playing with the addressing limits.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---

Reviewed-by: Nikolay Borisov <nborisov@suse.com>

> fs/btrfs/send.c | 18 ++++--------------
> 1 file changed, 4 insertions(+), 14 deletions(-)
>
> diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> index b082210df9c8..24b989fd130c 100644
> --- a/fs/btrfs/send.c
> +++ b/fs/btrfs/send.c
> @@ -539,33 +539,23 @@ static struct btrfs_path *alloc_path_for_send(void)
> static int write_buf(struct file *filp, const void *buf, u32 len, loff_t *off)
> {
> int ret;
> - mm_segment_t old_fs;
> u32 pos = 0;
>
> - old_fs = get_fs();
> - set_fs(KERNEL_DS);
> -
> while (pos < len) {
> - ret = vfs_write(filp, (__force const char __user *)buf + pos,
> - len - pos, off);
> + ret = kernel_write(filp, buf + pos, len - pos, off);
> /* TODO handle that correctly */
> /*if (ret == -ERESTARTSYS) {
> continue;
> }*/
> if (ret < 0)
> - goto out;
> + return ret;
> if (ret == 0) {
> - ret = -EIO;
> - goto out;
> + return -EIO;
> }
> pos += ret;
> }
>
> - ret = 0;
> -
> -out:
> - set_fs(old_fs);
> - return ret;
> + return 0;
> }
>
> static int tlv_put(struct send_ctx *sctx, u16 attr, const void *data, int len)
>

\
 
 \ /
  Last update: 2017-08-30 17:36    [W:0.130 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site