Messages in this thread | | | Date | Wed, 30 Aug 2017 16:02:49 +0100 | From | Mark Brown <> | Subject | Re: [RESEND PATCH 2/3] regulator: Add support for stm32-vrefbuf |
| |
On Wed, Aug 30, 2017 at 11:11:24AM +0200, Fabrice Gasnier wrote: > On 08/29/2017 08:57 PM, Mark Brown wrote: > > On Mon, Aug 28, 2017 at 02:58:52PM +0200, Fabrice Gasnier wrote:
> >> +static int __init stm32_vrefbuf_init(void) > >> +{ > >> + return platform_driver_register(&stm32_vrefbuf_driver); > >> +} > >> +subsys_initcall(stm32_vrefbuf_init);
> > Why is this at subsys_initcall()?
> Several consumers depend on it when it's being used, among which: STM32 > internal ADC and DAC, but also external components. Purpose is to ensure > it's ready before these drivers gets probed, instead of being deferred. > Is it ok to keep it ?
No, that's not OK - just let deferred probe handle it. The same thing applies to all regulator usage. [unhandled content-type:application/pgp-signature] | |