lkml.org 
[lkml]   [2017]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] char: xilinx_hwicap: Fix warnings in the driver
On Fri, Jul 28, 2017 at 03:17:26PM +0200, Michal Simek wrote:
> From: Nava kishore Manne <nava.manne@xilinx.com>
>
> This patch fixes the below warning
> --> Use #include <linux/io.h> instead of <asm/io.h>
> --> Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
> --> please, no space before tabs
> --> Block comments use a trailing */ on a separate line
> --> Possible unnecessary 'out of memory' message
> --> Block comments use * on subsequent lines
> --> Block comments use a trailing */ on a separate line
> --> braces {} are not necessary for any arm of this statement
> --> DT compatible string "xlnx,opb-hwicap-1.00.b"
> appears un-documented
> --> DT compatible string "xlnx,xps-hwicap-1.00.a"
> appears un-documented
>
> Signed-off-by: Nava kishore Manne <navam@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> Documentation/devicetree/bindings/xilinx.txt | 2 ++

It's preferred to split bindings to separate patches. No need unless you
respin:

Acked-by: Rob Herring <robh@kernel.org>

> drivers/char/xilinx_hwicap/xilinx_hwicap.c | 35 ++++++++++++++--------------
> drivers/char/xilinx_hwicap/xilinx_hwicap.h | 6 +++--
> 3 files changed, 23 insertions(+), 20 deletions(-)

\
 
 \ /
  Last update: 2017-08-04 00:33    [W:1.215 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site