lkml.org 
[lkml]   [2017]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 07/10] KVM: x86: remove not used pvclock_gtod_copy
From
Date
On 03/08/2017 01:21, Marcelo Tosatti wrote:
>> - if (ka->use_master_clock ||
>> - (gtod->clock.vclock_mode == VCLOCK_TSC && vcpus_matched))
>> + if (ka->use_master_clock || vcpus_matched)
>> kvm_make_request(KVM_REQ_MASTERCLOCK_UPDATE, vcpu);
> Don't drop this. The masterclock scheme requires TSC for proper functioning
> (or an analysis why its supposed with different HPET+TSC, for example).

I think testing gtod->clock.vclock_mode is just an optimization?
kvm_get_time_and_clockread would return false anyway and masterclock
would not be enabled.

Paolo

\
 
 \ /
  Last update: 2017-08-03 14:35    [W:0.063 / U:0.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site