lkml.org 
[lkml]   [2017]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/7] ACPI / blacklist: add acpi_match_oemlist() interface
    On Thu, Aug 03, 2017 at 03:57:47PM -0600, Toshi Kani wrote:
    > ACPI OEM ID / OEM Table ID / Revision can be used to identify
    > a platform based on ACPI firmware info. acpi_blacklisted(),
    > intel_pstate_platform_pwr_mgmt_exists(), and some other funcs,
    > have been using similar check to detect a list of platforms
    > that require special handlings.
    >
    > Move the platform check in acpi_blacklisted() to a new common
    > utility function, acpi_match_oemlist(), so that other drivers
    > do not have to implement their own version.
    >
    > There is no change in functionality.
    >
    > Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
    > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
    > Cc: Borislav Petkov <bp@alien8.de>
    > ---
    > drivers/acpi/blacklist.c | 83 ++++++++--------------------------------------
    > drivers/acpi/utils.c | 40 ++++++++++++++++++++++
    > include/linux/acpi.h | 19 +++++++++++
    > 3 files changed, 73 insertions(+), 69 deletions(-)
    >
    > diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
    > index bb542ac..bf44573 100644
    > --- a/drivers/acpi/blacklist.c
    > +++ b/drivers/acpi/blacklist.c
    > @@ -30,30 +30,13 @@
    >
    > #include "internal.h"
    >
    > -enum acpi_blacklist_predicates {
    > - all_versions,
    > - less_than_or_equal,
    > - equal,
    > - greater_than_or_equal,
    > -};
    > -
    > -struct acpi_blacklist_item {
    > - char oem_id[7];
    > - char oem_table_id[9];
    > - u32 oem_revision;
    > - char *table;
    > - enum acpi_blacklist_predicates oem_revision_predicate;
    > - char *reason;
    > - u32 is_critical_error;
    > -};
    > -
    > static struct dmi_system_id acpi_rev_dmi_table[] __initdata;
    >
    > /*
    > * POLICY: If *anything* doesn't work, put it on the blacklist.
    > * If they are critical errors, mark it critical, and abort driver load.
    > */
    > -static struct acpi_blacklist_item acpi_blacklist[] __initdata = {
    > +static struct acpi_oemlist acpi_blacklist[] __initdata = {

    All that wasted energy to try to explain to you that "oemlist" is wrong
    and that whole rename is pointless, went for nothing.

    So NAK.

    --
    Regards/Gruss,
    Boris.

    ECO tip #101: Trim your mails when you reply.
    --

    \
     
     \ /
      Last update: 2017-08-04 05:43    [W:2.710 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site