lkml.org 
[lkml]   [2017]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: use KERN_CONT in dump_pagetable()
On Thu, 24 Aug 2017, Jan Beulich wrote:

> The lack of newlines in preceding format strings is a clear indication
> that these were meant to be continuations of one another, and indeed
> output ends up quite a bit more compact (and readable) that way.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> arch/x86/mm/fault.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> --- 4.13-rc6/arch/x86/mm/fault.c
> +++ 4.13-rc6-x86-dumppgt-cont/arch/x86/mm/fault.c
> @@ -415,9 +415,9 @@ static void dump_pagetable(unsigned long
> goto out;
>
> pte = pte_offset_kernel(pmd, address);
> - printk("*pte = %0*Lx ", sizeof(*pte) * 2, (u64)pte_val(*pte));
> + printk(KERN_CONT "*pte = %0*Lx ", sizeof(*pte) * 2, (u64)pte_val(*pte));

Can you please make that pr_cont() while at it and change the pure
printk()s in that function to pr_info()?

Thanks,

tglx

\
 
 \ /
  Last update: 2017-08-26 00:09    [W:0.028 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site