lkml.org 
[lkml]   [2017]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 10/41] x86/apic: Remove the duplicated tracing versions of interrupts
On Fri, 25 Aug 2017 12:31:13 +0200
Thomas Gleixner <tglx@linutronix.de> wrote:

> The error and the spurious interrupt are really rare events and not at all
> so performance sensitive that two NOP5s can not be tolerated when tracing
> is disabled.

Just a note. I'm sure if we disassembled it, it may be a little more
work done than just two NOPs, as parameter passing to the tracepoints
sometimes leak out of the static jump block. It's moot on this patch,
but other irqs with fast paths may need to be looked at.

>
> Remove the nonsense.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> arch/x86/include/asm/hw_irq.h | 4 +--
> arch/x86/kernel/apic/apic.c | 43 +++++++++---------------------------------
> 2 files changed, 12 insertions(+), 35 deletions(-)
>

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

\
 
 \ /
  Last update: 2017-08-25 17:50    [W:0.243 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site