lkml.org 
[lkml]   [2017]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/3] ACPI / PMIC: Add opregion driver for Intel Dollar Cove TI PMIC
On Fri, 25 Aug 2017 17:24:19 +0200,
Andy Shevchenko wrote:
>
> On Fri, Aug 25, 2017 at 4:44 PM, Takashi Iwai <tiwai@suse.de> wrote:
>
> One really minor nit (fine if it will be ignored):
>
> > +config CHTDC_TI_PMIC_OPREGION
>
> CHTDC_TI_PMIC_OPREGION -> CHT_DC_TI_PMIC_OPREGION

Ah, the world is inconsistent...

> > obj-$(CONFIG_XPOWER_PMIC_OPREGION) += pmic/intel_pmic_xpower.o
> > obj-$(CONFIG_BXT_WC_PMIC_OPREGION) += pmic/intel_pmic_bxtwc.o
> > obj-$(CONFIG_CHT_WC_PMIC_OPREGION) += pmic/intel_pmic_chtwc.o
> > +obj-$(CONFIG_CHTDC_TI_PMIC_OPREGION) += pmic/intel_pmic_chtdc_ti.o
>
> Ditto (as you can notice by above context).

... where the file name is combined.

I really don't mind, too.

Rafael, please let me know if you want a resubmission with this
correction.


thanks,

Takashi

\
 
 \ /
  Last update: 2017-08-25 17:38    [W:0.034 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site