lkml.org 
[lkml]   [2017]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v2 2/2] fs: Add VirtualBox guest shared folder (vboxsf) support
Please merge the files into a a lot fewer files - basically
one .c file and a header for the protocol probably is enough.

Also kill all kinds of weird tiny wrappers that just obsfucate the code,
and make sure linux-fsdevel is on Cc for your next submission.

Also don't use i_private, instead defined alloc_inode and destroy_inode
methods and use container_of.

> +/**
> + * @note Anyone wishing to make changes here might wish to take a look at
> + * http://www.atnf.csiro.au/people/rgooch/linux/vfs.txt
> + * which seems to be the closest there is to official documentation on
> + * writing filesystem drivers for Linux.
> + */

And drop comments like this which will create a lot more confusion than
actually helping.

\
 
 \ /
  Last update: 2017-08-25 17:03    [W:0.033 / U:3.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site