lkml.org 
[lkml]   [2017]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] xfs: Drop setting redundant PF_KSWAPD in kswapd context
    On Thu, Aug 24, 2017 at 12:56:35PM +0200, Michal Hocko wrote:
    > On Thu 24-08-17 16:12:47, Anshuman Khandual wrote:
    > > xfs_btree_split() calls xfs_btree_split_worker() with args.kswapd set
    > > if current->flags alrady has PF_KSWAPD. Hence we should not again add
    > > PF_KSWAPD into the current flags inside kswapd context. So drop this
    > > redundant flag addition.
    >
    > I am not familiar with the code but your change seems incorect. The
    > whole point of args->kswapd is to convey the kswapd context to the
    > worker which is obviously running in a different context. So this patch
    > loses the kswapd context.

    Yup. That's what the code does, and removing the PF_KSWAPD from it
    will break it.

    Cheers,

    Dave.
    --
    Dave Chinner
    david@fromorbit.com

    \
     
     \ /
      Last update: 2017-08-25 02:02    [W:2.305 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site