lkml.org 
[lkml]   [2017]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] x86/microcode: Silence a static checker warning
On Thu, Aug 24, 2017 at 10:58:44PM +0200, Borislav Petkov wrote:
> On Thu, Aug 24, 2017 at 11:55:10PM +0300, Dan Carpenter wrote:
> > This is just cleanups and doesn't change the behavior.
>
> You can't return from in the middle of the loop just because the
> allocation fails.
>

I understand that.

> > The static checker is still going to complain about the error pointer
> > from the loop.
>
> Please drop this argument about the static checker which you write. I'm
> certainly not changing code just because some tool complains.

Sure. But the point is the same... The "p" is an error pointer at the
end of the function.

>
> > Perhaps we should only set prev_found if the memdup_patch()
> > inside the loop succeeds?
>
> This not why we set prev_found.

Sure.

regards,
dan carpenter

\
 
 \ /
  Last update: 2017-08-24 23:09    [W:0.064 / U:1.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site