Messages in this thread | ![/](/images/icornerl.gif) | | From | Nick Desaulniers <> | Date | Thu, 24 Aug 2017 09:25:41 -0700 | Subject | Re: [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses warning |
| |
bumping for review (resending, had gmail set to html mode)
On Mon, Aug 14, 2017 at 10:36 AM, Nick Desaulniers <ndesaulniers@google.com> wrote: > Minor nit for the commit message that can get fixed up when being merged: > > On Fri, Aug 11, 2017 at 11:16 AM, Nick Desaulniers > <ndesaulniers@google.com> wrote: > >> if (x) >> return >> ... >> >> rather than: >> >> if (!x == 0) > > should remove the `!`, ex: > > if (x == 0) > >> ... >> else >> return > > -- > Thanks, > ~Nick Desaulniers
-- Thanks, ~Nick Desaulniers
| ![\](/images/icornerr.gif) |