Messages in this thread | | | Date | Tue, 22 Aug 2017 18:35:55 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all part of PROVE_LOCKING |
| |
On Tue, Aug 22, 2017 at 05:59:06PM +0200, Oleg Nesterov wrote: > Peter, I'll read your email tomorrow, just one note... > > On 08/22, Peter Zijlstra wrote: > > > > Also^2, TJ, what's the purpose of using atomic_long_t for work->data? > > All it ever seems to do is atomic_long_read() and atomic_long_set(), > > plust set/clear bit, for example > > test_and_set_bit(WORK_STRUCT_PENDING_BIT, work_data_bits(work));
Ooh, that's unintuitive. That could certainly use a comment.
| |