lkml.org 
[lkml]   [2017]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 1/3] ASoC: codecs: msm8916-wcd-analog: get micbias voltage from dt
On Thu, Aug 17, 2017 at 10:02:09AM +0200, srinivas.kandagatla@linaro.org wrote:

> + /*
> + * Special headset needs MICBIAS as 2.7V so wait for
> + * 50 msec for the MICBIAS to reach 2.7 volts.
> + */
> + if (wcd->micbias_mv >= 2700)
> + msleep(50);

This doesn't sound like how ramping usually works? Normally it'd be at
least somewhat proportional to voltage, a sudden cutoff like this seems
strange. I'll apply but this looks like it needs fixing, please send an
incremental patch.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-08-21 20:25    [W:0.037 / U:0.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site