Messages in this thread | | | From | Masahiro Yamada <> | Date | Mon, 21 Aug 2017 21:29:27 +0900 | Subject | Re: [PATCH v3 1/4] mmc: sdhci-cadence: add suspend / resume support |
| |
Hi Adrian,
2017-08-21 20:48 GMT+09:00 Adrian Hunter <adrian.hunter@intel.com>:
>> +static int sdhci_cdns_resume(struct device *dev) >> +{ >> + struct sdhci_host *host = dev_get_drvdata(dev); >> + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); >> + struct sdhci_cdns_priv *priv = sdhci_pltfm_priv(pltfm_host); >> + int ret; >> + >> + ret = clk_prepare_enable(pltfm_host->clk); >> + if (ret) >> + return ret; >> + >> + ret = sdhci_cdns_phy_init(priv); >> + if (ret) >> + return ret; > > Perhaps clk_disable_unprepare(pltfm_host->clk) > >> + >> + return sdhci_resume_host(host); > > Ditto on error.
Thanks.
Maybe 3/4 should be fixed as well.
-- Best Regards Masahiro Yamada
| |