Messages in this thread Patch in this message | | | Date | Mon, 21 Aug 2017 02:16:21 -0700 | From | tip-bot for Ard Biesheuvel <> | Subject | [tip:efi/core] efi/libstub/arm64: Force 'hidden' visibility for section markers |
| |
Commit-ID: 0426a4e68f18d75515414361de9e3e1445d2644e Gitweb: http://git.kernel.org/tip/0426a4e68f18d75515414361de9e3e1445d2644e Author: Ard Biesheuvel <ard.biesheuvel@linaro.org> AuthorDate: Fri, 18 Aug 2017 20:49:36 +0100 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Mon, 21 Aug 2017 09:43:49 +0200
efi/libstub/arm64: Force 'hidden' visibility for section markers
To prevent the compiler from emitting absolute references to the section markers when running in PIC mode, override the visibility to 'hidden' for all contents of asm/sections.h
Tested-by: Matthias Kaehlcke <mka@chromium.org> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Matt Fleming <matt@codeblueprint.co.uk> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: linux-efi@vger.kernel.org Link: http://lkml.kernel.org/r/20170818194947.19347-4-ard.biesheuvel@linaro.org Signed-off-by: Ingo Molnar <mingo@kernel.org> --- drivers/firmware/efi/libstub/arm64-stub.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/libstub/arm64-stub.c b/drivers/firmware/efi/libstub/arm64-stub.c index b4c2589..f7a6970 100644 --- a/drivers/firmware/efi/libstub/arm64-stub.c +++ b/drivers/firmware/efi/libstub/arm64-stub.c @@ -9,9 +9,17 @@ * published by the Free Software Foundation. * */ + +/* + * To prevent the compiler from emitting GOT-indirected (and thus absolute) + * references to the section markers, override their visibility as 'hidden' + */ +#pragma GCC visibility push(hidden) +#include <asm/sections.h> +#pragma GCC visibility pop + #include <linux/efi.h> #include <asm/efi.h> -#include <asm/sections.h> #include <asm/sysreg.h> #include "efistub.h"
| |