Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 18 Aug 2017 15:38:56 +0300 | Subject | Re: [RFC v1 4/6] platform: x86: Add generic Intel IPC driver |
| |
On Tue, Aug 1, 2017 at 9:13 PM, <sathyanarayanan.kuppuswamy@linux.intel.com> wrote: > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > > Currently intel_scu_ipc.c, intel_pmc_ipc.c and intel_punit_ipc.c > redundantly implements the same IPC features and has lot of code > duplication between them. This driver addresses this issue by grouping > the common IPC functionalities under the same driver. > > Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > --- > arch/x86/include/asm/intel_ipc_dev.h | 148 ++++++++++++
No, it should go under include/linux/platform_data/x86/
> +/* > + * intel_ipc_dev.h: IPC class device header file
No file names in the top of files.
> + * > + * (C) Copyright 2017 Intel Corporation > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License > + * as published by the Free Software Foundation; version 2 > + * of the License. > + * > + */
> +struct intel_ipc_dev_cfg { > + void __iomem *base; > + void __iomem *wrbuf_reg; > + void __iomem *rbuf_reg; > + void __iomem *sptr_reg; > + void __iomem *dptr_reg; > + void __iomem *status_reg; > + void __iomem *cmd_reg;
No, you have to switch to regmap instead.
> + int mode; > + int irq; > + int irqflags; > + int chan_type; > + bool use_msi; > +};
-- With Best Regards, Andy Shevchenko
| |