Messages in this thread | | | Date | Thu, 17 Aug 2017 13:16:42 -0600 | From | Jason Gunthorpe <> | Subject | Re: [PATCH] tpm: vtpm: constify vio_device_id |
| |
On Thu, Aug 17, 2017 at 11:04:21PM +0530, Arvind Yadav wrote: > vio_device_id are not supposed to change at runtime. All functions > working with vio_device_id provided by <asm/vio.h> work with > const vio_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> drivers/char/tpm/tpm_ibmvtpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c > index f01d083..d2ce46b 100644 > +++ b/drivers/char/tpm/tpm_ibmvtpm.c > @@ -32,7 +32,7 @@ > > static const char tpm_ibmvtpm_driver_name[] = "tpm_ibmvtpm"; > > -static struct vio_device_id tpm_ibmvtpm_device_table[] = { > +static const struct vio_device_id tpm_ibmvtpm_device_table[] = { > { "IBM,vtpm", "IBM,vtpm"}, > { "", "" } > };
| |