lkml.org 
[lkml]   [2017]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC][PATCH 2/2] selftests: timers: freq-step: Fix build warning
From
Date
Hi John,

On 08/15/2017 06:11 AM, Miroslav Lichvar wrote:
> On Mon, Aug 14, 2017 at 02:01:36PM -0700, John Stultz wrote:
>> Fixes the following build warning:
>> freq-step.c: In function ‘main’:
>> freq-step.c:271:1: warning: control reaches end of non-void function [-Wreturn-type]
>
>> @@ -268,4 +268,6 @@ int main(int argc, char **argv)
>> ksft_exit_fail();

This needs to be changes as well to return ksft_exit_fail();
>>
>> ksft_exit_pass();
>> +
>> + return 0;
>> }
>
> It seems most tests use "return ksft_exit_pass();". Would that be
> preferred over separate return? I don't have a preference.

Let's go with "return ksft_exit_pass();"
>
> Both patches in this set look good to me.
>
> Thanks,
>

thanks,
-- Shuah

\
 
 \ /
  Last update: 2017-08-17 01:02    [W:0.038 / U:1.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site