| Subject | Re: [PATCH 4.4 15/58] iscsi-target: Fix initial login PDU asynchronous socket close OOPs | From | Ben Hutchings <> | Date | Fri, 11 Aug 2017 17:12:39 +0100 |
| |
On Wed, 2017-08-09 at 12:41 -0700, Greg Kroah-Hartman wrote: > 4.4-stable review patch. If anyone has any objections, please let me > know. > > ------------------ > > From: Nicholas Bellinger <nab@linux-iscsi.org> > > commit 25cdda95fda78d22d44157da15aa7ea34be3c804 upstream. [...] > --- a/drivers/target/iscsi/iscsi_target_nego.c > +++ b/drivers/target/iscsi/iscsi_target_nego.c > @@ -489,14 +489,60 @@ static void iscsi_target_restore_sock_ca > > static int iscsi_target_do_login(struct iscsi_conn *, struct iscsi_login *); > > -static bool iscsi_target_sk_state_check(struct sock *sk) > +static bool __iscsi_target_sk_check_close(struct sock *sk) > { > if (sk->sk_state == TCP_CLOSE_WAIT || sk->sk_state == TCP_CLOSE) { > - pr_debug("iscsi_target_sk_state_check: TCP_CLOSE_WAIT|TCP_CLOSE," > + pr_debug("__iscsi_target_sk_check_close: TCP_CLOSE_WAIT|TCP_CLOSE," > "returning FALSE\n"); > - return false; > + return true; [...]
The log message no longer matches the code. This seems to be unfixed upstream.
Ben.
-- Ben Hutchings Software Developer, Codethink Ltd.
|