Messages in this thread | | | Subject | Re: [PATCH] ASoC: Freescale: Delete an error message for a failed memory allocation in three functions | From | Joe Perches <> | Date | Fri, 11 Aug 2017 07:44:31 -0700 |
| |
On Fri, 2017-08-11 at 15:32 +0200, SF Markus Elfring wrote: > From 885ccd6c63291dcd4854a0cbaab5188cdc3db805 Mon Sep 17 00:00:00 2001 > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Fri, 11 Aug 2017 15:10:43 +0200 > Subject: [PATCH] ASoC: Freescale: Delete an error message for a failed memory allocation in three functions > > Omit an extra message for a memory allocation failure in these functions. > > This issue was detected by using the Coccinelle software. > > Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
This doesn't have anything to do with refactoring strings.
Just note that allocations without GFP_NOWARN do a dump_stack()
> diff --git a/sound/soc/fsl/fsl_asrc_dma.c b/sound/soc/fsl/fsl_asrc_dma.c [] > @@ -282,7 +282,5 @@ static int fsl_asrc_dma_startup(struct snd_pcm_substream *substream) > - if (!pair) { > - dev_err(dev, "failed to allocate pair\n"); > + if (!pair) > return -ENOMEM; > - }
Use normal diff output that shows 3 lines of context above and below the patched lines.
| |