Messages in this thread | | | Subject | Re: [PATCH v3 13/28] drm/mediatek: switch to drm_*_get(), drm_*_put() helpers | From | Philipp Zabel <> | Date | Fri, 11 Aug 2017 15:01:40 +0200 |
| |
On Fri, 2017-08-11 at 15:32 +0300, Cihangir Akturk wrote: > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() > and drm_*_unreference() helpers. > > drm_*_reference() and drm_*_unreference() functions are just > compatibility alias for drm_*_get() and drm_*_put() and should not be > used by new code. So convert all users of compatibility functions to > use the new APIs. > > Generated by: scripts/coccinelle/api/drm-get-put.cocci > > Signed-off-by: Cihangir Akturk <cakturk@gmail.com> > --- > drivers/gpu/drm/mediatek/mtk_drm_fb.c | 4 ++-- > drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_fb.c > b/drivers/gpu/drm/mediatek/mtk_drm_fb.c > index d4246c9..0d8d506 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_fb.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_fb.c > @@ -58,7 +58,7 @@ static void mtk_drm_fb_destroy(struct > drm_framebuffer *fb) > > drm_framebuffer_cleanup(fb); > > - drm_gem_object_unreference_unlocked(mtk_fb->gem_obj); > + drm_gem_object_put_unlocked(mtk_fb->gem_obj); > > kfree(mtk_fb); > } > @@ -160,6 +160,6 @@ struct drm_framebuffer > *mtk_drm_mode_fb_create(struct drm_device *dev, > return &mtk_fb->base; > > unreference: > - drm_gem_object_unreference_unlocked(gem); > + drm_gem_object_put_unlocked(gem); > return ERR_PTR(ret); > } > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c > b/drivers/gpu/drm/mediatek/mtk_drm_gem.c > index 8ec963f..f595ac8 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c > @@ -122,7 +122,7 @@ int mtk_drm_gem_dumb_create(struct drm_file > *file_priv, struct drm_device *dev, > goto err_handle_create; > > /* drop reference from allocate - handle holds it now. */ > - drm_gem_object_unreference_unlocked(&mtk_gem->base); > + drm_gem_object_put_unlocked(&mtk_gem->base); > > return 0; >
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards Philipp
| |