lkml.org 
[lkml]   [2017]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 0/4] net-next: dsa: fix flow dissection
    From
    Date
    On Wed, 2017-08-09 at 22:52 -0700, David Miller wrote:
    > From: John Crispin <john@phrozen.org>
    > Date: Wed, 9 Aug 2017 14:41:15 +0200
    >
    > > RPS and probably other kernel features are currently broken on some if not
    > > all DSA devices. The root cause of this is that skb_hash will call the
    > > flow_dissector. At this point the skb still contains the magic switch
    > > header and the skb->protocol field is not set up to the correct 802.3
    > > value yet. By the time the tag specific code is called, removing the header
    > > and properly setting the protocol an invalid hash is already set. In the
    > > case of the mt7530 this will result in all flows always having the same
    > > hash.
    > >
    > > Changes since RFC:
    > > * use a callback instead of static values
    > > * add cover letter
    >
    > Series applied, thanks.

    Is this related ?

    net/core/flow_dissector.c: In function '__skb_flow_dissect':
    net/core/flow_dissector.c:448:18: error: 'struct net_device' has no member named 'dsa_ptr'
    ops = skb->dev->dsa_ptr->tag_ops;
    ^
    make[3]: *** [net/core/flow_dissector.o] Error 1


    \
     
     \ /
      Last update: 2017-08-10 08:43    [W:4.965 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site