Messages in this thread | | | Subject | Re: blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage | From | Jens Axboe <> | Date | Tue, 1 Aug 2017 09:26:09 -0600 |
| |
On 08/01/2017 12:55 AM, Michael Ellerman wrote: > Jens Axboe <axboe@kernel.dk> writes: > ... >> >> Can you try the below fix? Should be more palatable than the previous >> one. Brian, maybe you can take a look at the IRQ issue mentioned above? > > Given the patch from Brian fixed the lockdep warning, do you still want > me to try and test this one?
Nope, we don't have to do that. I'd much rather just add a WARN_ON() or similar to make sure we catch buggy users earlier. scsi_run_queue() needs a
WARN_ON(in_interrupt());
but it might be better to put that in __blk_mq_run_hw_queue().
-- Jens Axboe
| |