Messages in this thread | | | From | Amitoj Kaur Chawla <> | Date | Sat, 8 Jul 2017 18:55:48 -0400 | Subject | Re: [PATCH 2/2] staging: media: atomisp2: Replace kfree()/vfree() with kvfree() |
| |
On Sat, Jul 8, 2017 at 4:58 AM, Bernd Petrovitsch <bernd@petrovitsch.priv.at> wrote: > On Fri, 2017-07-07 at 20:41 -0400, Amitoj Kaur Chawla wrote: > [...] >> --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c >> +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c >> @@ -117,11 +117,7 @@ void *atomisp_kernel_zalloc(size_t bytes, bool >> zero_mem) >> */ >> void atomisp_kernel_free(void *ptr) >> { >> - /* Verify if buffer was allocated by vmalloc() or kmalloc() >> */ >> - if (is_vmalloc_addr(ptr)) >> - vfree(ptr); >> - else >> - kfree(ptr); >> + kvfree(ptr); >> } >> >> /* > > Why not get rid of the trivial wrapper function completely? >
Oh yes, i'll send a v2.
Amitoj
| |