lkml.org 
[lkml]   [2017]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] iio: multiplexer: add NULL check on devm_kzalloc() return value
    Check return value from call to devm_kzalloc()
    in order to prevent a NULL pointer dereference.

    This issue was detected using Coccinelle and the following semantic patch:

    @@
    expression x;
    identifier fld;
    @@

    * x = devm_kzalloc(...);
    ... when != x == NULL
    x->fld


    Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
    ---
    drivers/iio/multiplexer/iio-mux.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/iio/multiplexer/iio-mux.c b/drivers/iio/multiplexer/iio-mux.c
    index 37ba007..a8d672b 100644
    --- a/drivers/iio/multiplexer/iio-mux.c
    +++ b/drivers/iio/multiplexer/iio-mux.c
    @@ -285,6 +285,9 @@ static int mux_configure_channel(struct device *dev, struct mux *mux,
    child->ext_info_cache = devm_kzalloc(dev,
    sizeof(*child->ext_info_cache) *
    num_ext_info, GFP_KERNEL);
    + if (!child->ext_info_cache)
    + return -ENOMEM;
    +
    for (i = 0; i < num_ext_info; ++i) {
    child->ext_info_cache[i].size = -1;

    --
    2.5.0
    \
     
     \ /
      Last update: 2017-07-07 00:09    [W:4.269 / U:0.588 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site