Messages in this thread | | | From | Gilad Ben-Yossef <> | Date | Thu, 27 Jul 2017 17:26:18 +0300 | Subject | Re: [PATCH v2 1/3] staging: ccree: Replace kzalloc with devm_kzalloc |
| |
On Tue, Jul 18, 2017 at 1:58 PM, <sunil.m@techveda.org> wrote: > From: Suniel Mahesh <sunil.m@techveda.org> > > It is recommended to use managed function devm_kzalloc, which > simplifies driver cleanup paths and driver code. > This patch does the following: > (a) replace kzalloc with devm_kzalloc. > (b) drop kfree(), because memory allocated with devm_kzalloc() is > automatically freed on driver detach, otherwise it leads to a double > free. > (c) remove unnecessary blank lines. > > Signed-off-by: Suniel Mahesh <sunil.m@techveda.org> > --- > Changes for v2: > > - Changes done as suggested by Greg-KH. > - Rebased on top of next-20170718. > --- > Note: > > - Patch was tested and built(ARCH=arm) on next-20170718. > No build issues reported, however it was not tested on > real hardware.
I verified the patch set on CrytoCell HW and it's fine.
Unfortunately, my coding style fixes patch set made two of these to fail to apply. Following up is a rebased patch. There are no changes except resolving conflicts.
-- Gilad Ben-Yossef Chief Coffee Drinker
"If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru
| |