lkml.org 
[lkml]   [2017]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 2/4] mm: add file_fdatawait_range and file_write_and_wait
    On Wed 26-07-17 13:55:36, Jeff Layton wrote:
    > +int file_write_and_wait(struct file *file)
    > +{
    > + int err = 0, err2;
    > + struct address_space *mapping = file->f_mapping;
    > +
    > + if ((!dax_mapping(mapping) && mapping->nrpages) ||
    > + (dax_mapping(mapping) && mapping->nrexceptional)) {
    > + err = filemap_fdatawrite(mapping);
    > + /* See comment of filemap_write_and_wait() */
    > + if (err != -EIO) {
    > + loff_t i_size = i_size_read(mapping->host);
    > +
    > + if (i_size != 0)
    > + __filemap_fdatawait_range(mapping, 0,
    > + i_size - 1);
    > + }
    > + }

    Err, what's the i_size check doing here? I'd just pass ~0 as the end of the
    range and ignore i_size. It is much easier than trying to wrap your head
    around possible races with file operations modifying i_size.

    Honza
    --
    Jan Kara <jack@suse.com>
    SUSE Labs, CR

    \
     
     \ /
      Last update: 2017-07-27 10:51    [W:3.035 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site