Messages in this thread | ![/](/images/icornerl.gif) | | From | "Levin, Alexander (Sasha Levin)" <> | Subject | Re: [PATCH] net: inet: diag: expose sockets cgroup classid | Date | Wed, 26 Jul 2017 22:59:19 +0000 |
| |
On Wed, Jul 26, 2017 at 03:01:32PM -0700, Cong Wang wrote: >On Wed, Jul 26, 2017 at 10:22 AM, Levin, Alexander (Sasha Levin) ><alexander.levin@verizon.com> wrote: >> + if (ext & (1 << (INET_DIAG_CLASS_ID - 1))) { >> + u32 classid = 0; >> + >> +#ifdef CONFIG_SOCK_CGROUP_DATA >> + classid = sock_cgroup_classid(&sk->sk_cgrp_data); >> +#endif > > >If CONFIG_SOCK_CGROUP_DATA is not enabled, should we put 0 >or put nothing (that is, skipping this nla_put())?
My logic was that if CONFIG_SOCK_CGROUP_DATA is disabled, then all sockets have the same default classid ==> 0, rather than having to deal with whether that config is enabled or not.
>> + >> + nla_put(skb, INET_DIAG_CLASS_ID, sizeof(classid), &classid); > >nla_put_u32()
Will fix, thanks!
--
Thanks, Sasha
| ![\](/images/icornerr.gif) |