Messages in this thread | ![/](/images/icornerl.gif) | | From | Rob Herring <> | Date | Tue, 25 Jul 2017 15:36:29 -0500 | Subject | Re: [PATCH v4 2/2] of: Add unit tests for applying overlays |
| |
On Tue, Apr 25, 2017 at 7:09 PM, <frowand.list@gmail.com> wrote: > From: Frank Rowand <frank.rowand@sony.com> > > Existing overlay unit tests examine individual pieces of the overlay > code. The new tests target the entire process of applying an overlay. > > Signed-off-by: Frank Rowand <frank.rowand@sony.com> > ---
[...]
> @@ -1261,6 +1263,8 @@ void __init unflatten_device_tree(void) > > /* Get pointer to "/chosen" and "/aliases" nodes for use everywhere */ > of_alias_scan(early_init_dt_alloc_memory_arch); > + > + unittest_unflatten_overlay_base();
This breaks on systems that don't boot with FDT and call unflatten_device_tree, namely x86 and UML (UML needs a few hacks to work) which was a feature of the unittest. Considering applying overlays on x86 is something we'll want to support, the unittest should support that case.
Rob
| ![\](/images/icornerr.gif) |