Messages in this thread | | | From | Kees Cook <> | Date | Mon, 24 Jul 2017 15:27:07 -0700 | Subject | Re: [PATCH 07/11] mfd: Drop unnecessary static |
| |
On Mon, Jul 24, 2017 at 12:20 PM, Pavel Machek <pavel@ucw.cz> wrote: > Hi! > >> > > Drop static on a local variable, when the variable is initialized before >> > > any possible use. Thus, the static has no benefit. > > Actually... it has possible other benefit -- saving stack space. I've > used static for that purpose before. So ... careful with the > automation.
This means any functions like this must not be thread safe, though...
-Kees
-- Kees Cook Pixel Security
| |